Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.14.z] Pytest verifies and log-in into vault #12766

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[6.14.z] Pytest verifies and log-in into vault #12766

merged 1 commit into from
Oct 4, 2023

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Sep 28, 2023 •
edited
Loading

CherryPick of #12378
fixes: #12760

Pytest session now verifies the vault session first.

  • If the session expired, it takes you to login, and once logged in, it continues to the next step
  • If the session is running, it just continues
  • This only works for local execution and not in CI as CI has AppRole credentials directly!

@jyejare
Pytest verifies and log-in into vault (SatelliteQE#12378)
a650be2 
* Pytest verifies and logs in into vault

* New vault lib utils for both

* PR checks without vault login
@jyejare jyejare changed the title 6.14.z [6.14.z] Pytest verifies and log-in into vault Sep 28, 2023
@jyejare jyejare added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 labels Sep 28, 2023
@jyejare
Copy link
Member Author

jyejare commented Oct 3, 2023

trigger: test-robottelo
pytest: tests/foreman/api/test_product.py

@Gauravtalreja1 Gauravtalreja1 merged commit 0b61818 into SatelliteQE:6.14.z Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@jyejare jyejare

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyejare @Gauravtalreja1 @ColeHiggins2